Modular data services #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ftian1
approved these changes
Jul 23, 2024
|
looks good to me |
|
Error is coming from outdated docker-compose on the runner. Minimum required docker-compose version for include is 2.20 |
|
@sunnstix, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support the usage and implementation of other databases including redis, qdrant, and pgvector, I modified the compose files to use an include for the three microservices corresponding to data serving and retrieval (vector-db, retriever, and dataprep).
Issues
Tangentially related to #439
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Ran existing test on xeon to verify that these changes didn't affect the existing redis implementation. Manually mutated the file to modify the DATA_SERVICE environment variable (as well as corresponding variables such as PG_CONNECTION_STRING) and verified that this works with pgvector and qdrant.