Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinecone update to Readme and docker compose for ChatQnA #540

Merged
merged 61 commits into from
Nov 13, 2024
Merged

Pinecone update to Readme and docker compose for ChatQnA #540

merged 61 commits into from
Nov 13, 2024

Conversation

pallavijaini0525
Copy link
Collaborator

Description

Added the Readme and Docker compose files for Pinecone DB for ChatQnA usecase

Issues

#411

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Others (enhancement, documentation, validation, etc.)

@pallavijaini0525 pallavijaini0525 mentioned this pull request Aug 7, 2024
Open
@chensuyue
Copy link
Collaborator

  1. Do we need a separate readme?
  2. ChatQnA/docker/xeon/docker_compose_pinecone.yaml --> ChatQnA/docker/xeon/compose_pinecone.yaml
  3. Please add an example e2e test, like this one, https://github.com/opea-project/GenAIExamples/blob/main/ChatQnA/tests/test_chatqna_on_xeon.sh

@pallavijaini0525
Copy link
Collaborator Author

@chensuyue -> Sure i will add the tests, can you please help in adding the PINECONE_KEY to the project variables simialr to HF_TOKEN, so i can use that key for the tests.

@ZePan110 has added for GenAIComps

@chensuyue chensuyue mentioned this pull request Aug 13, 2024
Merged
4 tasks
@chensuyue
Copy link
Collaborator

@chensuyue -> Sure i will add the tests, can you please help in adding the PINECONE_KEY to the project variables simialr to HF_TOKEN, so i can use that key for the tests.

@ZePan110 has added for GenAIComps

#579

@pallavijaini0525
Copy link
Collaborator Author

Tests are added and file is renamed to compose_pinecone.yaml

@arun-gupta
Copy link
Contributor

What is the current status of this merge?

In addition, can opea/*-pinecone Docker images be pushed to Docker Hub? This will simplify the overall developer experience.

@pallavijaini0525
Copy link
Collaborator Author

Only the docker compose and Readme files are not merged which are part of this PR, In GenAIComps, pinecone related changes are merged

@arun-gupta
Copy link
Contributor

Seems like @chensuyue requested some changes. Can we make them so that it can be integrated?

@pallavijaini0525 pallavijaini0525 force-pushed the pinecone_update branch 3 times, most recently from 331e481 to 2088b19 Compare September 11, 2024 15:43
@pallavijaini0525
Copy link
Collaborator Author

@chensuyue -> All issues are resolved, please review

@chensuyue
Copy link
Collaborator

@chensuyue -> All issues are resolved, please review

Because the test scripts name not adapt to the new structure, the test is actually not triggered.

@pallavijaini0525 pallavijaini0525 force-pushed the pinecone_update branch 7 times, most recently from e13bce5 to a5ade94 Compare September 18, 2024 15:50
AI Workloads and others added 9 commits October 16, 2024 04:48
Corrected the tag
429be00 
Signed-off-by: AI Workloads <[email protected]>
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
Corrected the ports
1ab8626 
Signed-off-by: AI Workloads <[email protected]>
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
@pallavijaini0525
Commented out dataprep as not able to connect to pineconeserver
05a6b65 
Signed-off-by: Pallavi Jaini <[email protected]>
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
70b7159 
for more information, see https://pre-commit.ci

Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
@pallavijaini0525
Added more comments
7628f33 
Signed-off-by: Pallavi Jaini <[email protected]>
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
Validated in IDC and enabled all the tests in pinecone
98d8eb4 
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
19f95bf 
for more information, see https://pre-commit.ci

Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
Merge remote-tracking branch 'origin/pinecone_update' into pinecone_u…
1a59f91 
…pdate
Implemented all review comments
6aa1720 
Signed-off-by: Pallavi Jaini <pallavi,[email protected]>
@chensuyue chensuyue mentioned this pull request Oct 16, 2024
Merged
4 tasks
@chensuyue chensuyue added this to the v1.1 milestone Nov 12, 2024
@lvliang-intel lvliang-intel merged commit 0d52c2f into opea-project:main Nov 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZePan110 ZePan110 ZePan110 approved these changes

@chensuyue chensuyue chensuyue approved these changes

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel lvliang-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@pallavijaini0525 @chensuyue @arun-gupta @ZePan110 @lvliang-intel