react-ui: Add support to display Chinese #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chensuyue @lvliang-intel Hi Suyue, Liang, I see the following errors from CI run-test:
But I don't think it's related to the code I changed. Could you please help take a look and let me know if anything I missed. |
lvliang-intel
approved these changes
Sep 3, 2024
jaswanth8888
approved these changes
Sep 3, 2024
llm-tgi microservice from GenAIComps has encoded each text, so Chinese response will be shown as hexadecimal in react UI. Add support to decode and display the response in Chinese. Also return raw response if no pattern found. Signed-off-by: Cathy Zhang <[email protected]> Signed-off-by: Ruoyu Ying <[email protected]>
for more information, see https://pre-commit.ci
Ruoyu-y
force-pushed
the
add-chinese-support
branch
from
adaecab
to
846d278
Compare
xuechendi
pushed a commit
to xuechendi/GenAIExamples
that referenced
this pull request
Sep 9, 2024
* react-ui: Add support to display Chinese llm-tgi microservice from GenAIComps has encoded each text, so Chinese response will be shown as hexadecimal in react UI. Add support to decode and display the response in Chinese. Also return raw response if no pattern found. Signed-off-by: Cathy Zhang <[email protected]> Signed-off-by: Ruoyu Ying <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Cathy Zhang <[email protected]> Signed-off-by: Ruoyu Ying <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
dmsuehir
pushed a commit
to dmsuehir/GenAIExamples
that referenced
this pull request
Sep 11, 2024
* react-ui: Add support to display Chinese llm-tgi microservice from GenAIComps has encoded each text, so Chinese response will be shown as hexadecimal in react UI. Add support to decode and display the response in Chinese. Also return raw response if no pattern found. Signed-off-by: Cathy Zhang <[email protected]> Signed-off-by: Ruoyu Ying <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Cathy Zhang <[email protected]> Signed-off-by: Ruoyu Ying <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llm-tgi microservice from GenAIComps has encoded each output text, so Chinese response will be shown as hexadecimal in react UI. Add support to decode and display the response in Chinese correctly.