Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VideoRAGQnA as MMRAG usecase in Example #744

Merged
merged 34 commits into from
Sep 11, 2024

Conversation

BaoHuiling
Copy link
Contributor

@BaoHuiling BaoHuiling commented Sep 5, 2024

Description

Add VideoRAGQnA as MMRAG usecase in Example

Issues

#358

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

streamlit

Tests

VideoRAGQnA/tests/test_compose_on_xeon.sh

@BaoHuiling BaoHuiling changed the title Example dev Add VideoRAGQnA as MMRAG usecase in Example Sep 5, 2024
@BaoHuiling
Copy link
Contributor Author

The test is WIP, and it will only work when opea-project/GenAIComps#621 and opea-project/GenAIComps#603 is merged. please hold
@lvliang-intel @chensuyue could you help to tag the PR milestone for 1.0?

@chensuyue chensuyue added this to the v1.0 milestone Sep 5, 2024
@tileintel tileintel mentioned this pull request Sep 6, 2024
@lvliang-intel
Copy link
Collaborator

@BaoHuiling,
About the CI issue, you should put the 'tests' directory in the ‘MultiModalRAGQnA’.
Why do you set two level folders for this example?

image

@BaoHuiling
Copy link
Contributor Author

BaoHuiling commented Sep 6, 2024

@BaoHuiling, About the CI issue, you should put the 'tests' directory in the ‘MultiModalRAGQnA’. Why do you set two level folders for this example?

image

Hi Liang, thanks for comment, because we are contributing 2 use cases for the MMRAG, there will be another usercase under MultiModalRAGQnA see #358 (comment)

I will move the test to upper folder.

@BaoHuiling
Copy link
Contributor Author

BaoHuiling commented Sep 11, 2024

Waiting for opea-project/GenAIComps#621 merged
Update: merged

@BaoHuiling
Copy link
Contributor Author

@lvliang-intel @kevinintel @XuhuiRen @Spycsh Hi all, this PR finished the file strcture update and passed all CI test, could you help to review and merge it? Thanks a lot

@BaoHuiling
Copy link
Contributor Author

@yinghu5 @chensuyue Add more reviewers🙂

@kevinintel kevinintel merged commit 2dd69dc into opea-project:main Sep 11, 2024
12 checks passed
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
Signed-off-by: BaoHuiling <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kevinintel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants