-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ChatQnA README.md #762
Conversation
Add pull docker images from docker hub Signed-off-by: Wang, Xigui <[email protected]>
for more information, see https://pre-commit.ci
@@ -57,6 +57,34 @@ chaqna-xeon-ui-server | |||
Port 5173 - Open to 0.0.0.0/0 | |||
``` | |||
|
|||
You can pull ChatQnA and components docker images form docker hub or build images from source code. | |||
|
|||
## 🚀 Pull docker images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to pull the image manually, when you run docker compose, the image will be pull automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, there is no need to pull the Docker images explicitly at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on this change as some images are behind in terms of approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flow of instructions can be further simplified.
@@ -57,6 +57,34 @@ chaqna-xeon-ui-server | |||
Port 5173 - Open to 0.0.0.0/0 | |||
``` | |||
|
|||
You can pull ChatQnA and components docker images form docker hub or build images from source code. | |||
|
|||
## 🚀 Pull docker images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, there is no need to pull the Docker images explicitly at all.
``` | ||
|
||
Go to [Section Check Docker Images)](#Check-Docker-Images) | ||
|
||
## 🚀 Build Docker Images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be moved to a backup section. Keep the flow simple for developer to get started.
Add pull docker images from docker hub
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
#412
Type of change
Document update
Dependencies
No
Tests
Verified pull down docker images works as expected.