UI: support get and delete existing files in conversation UI #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add file display and delete * support chinese output Signed-off-by: Ruoyu Ying <[email protected]>
* modify datasource scss * modify configs Signed-off-by: Ruoyu Ying <[email protected]>
for more information, see https://pre-commit.ci
3 tasks
| VITE_DATA_PREP_SERVICE_URL=http://backend_address:6007/v1/dataprep |
There was a problem hiding this comment.
We use nginx to forward messages from the frontend to the backend, just need to provide endpoint name here.
There was a problem hiding this comment.
So the env should be set as sth like this?
VITE_DATA_PREP_SERVICE_URL=/v1/dataprep
VITE_DATAPREP_GET_FILE_ENDPOINT=/v1/dataprep/get_file
VITE_DATAPREP_DELETE_FILE_ENDPOINT=/v1/dataprep/delete_file
|
@Ruoyu-y do we still need this PR? |
WenjiaoYue
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the file display for files that has already been uploaded in conversation UI through /v1/dataprep/get_file.
Support file delete in conversation UI.
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.