Skip to content

Commit

Permalink
helm: remove unused Probes
Browse files Browse the repository at this point in the history
- Remove unused probes

- Support conditionally disable probes per GMC request

Signed-off-by: Lianhao Lu <[email protected]>
  • Loading branch information
lianhao authored and yongfengdu committed Jul 17, 2024
1 parent ab53e95 commit c1cff5f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 44 deletions.
20 changes: 0 additions & 20 deletions helm-charts/common/asr/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,6 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp
#startupProbe:
# exec:
# command:
# - curl
# {{- if .Values.ASR_ENDPOINT }}
# - {{ .Values.ASR_ENDPOINT }}
# {{- else }}
# - http://{{ .Release.Name }}-whisper
# {{- end }}
# initialDelaySeconds: 5
# periodSeconds: 5
# failureThreshold: 120
# livenessProbe:
# httpGet:
# path: /
# port: 7000
# readinessProbe:
# httpGet:
# path: /
# port: 7000
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down
8 changes: 0 additions & 8 deletions helm-charts/common/data-prep/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp
# livenessProbe:
# httpGet:
# path: /
# port: 7000
# readinessProbe:
# httpGet:
# path: /
# port: 7000
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/common/llm-uservice/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp
{{- if not .Values.noProbe }}
startupProbe:
exec:
command:
Expand All @@ -60,6 +61,7 @@ spec:
initialDelaySeconds: 5
periodSeconds: 5
failureThreshold: 120
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down
10 changes: 2 additions & 8 deletions helm-charts/common/retriever-usvc/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp
{{- if not .Values.noProbe }}
startupProbe:
exec:
command:
Expand All @@ -60,14 +61,7 @@ spec:
initialDelaySeconds: 5
periodSeconds: 5
failureThreshold: 120
# livenessProbe:
# httpGet:
# path: /
# port: 7000
# readinessProbe:
# httpGet:
# path: /
# port: 7000
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down
10 changes: 2 additions & 8 deletions helm-charts/common/web-retriever/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp
{{- if not .Values.noProbe }}
startupProbe:
exec:
command:
Expand All @@ -60,14 +61,7 @@ spec:
initialDelaySeconds: 5
periodSeconds: 5
failureThreshold: 120
# livenessProbe:
# httpGet:
# path: /
# port: 7000
# readinessProbe:
# httpGet:
# path: /
# port: 7000
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down

0 comments on commit c1cff5f

Please sign in to comment.