Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GMC system installation on push #158

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

daisy-ycguo
Copy link
Collaborator

Description

Enable GMC system installation on push

Issues

closes #156

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a

Tests

CI tests, verified in this action: https://github.com/opea-project/GenAIInfra/actions/runs/9803891746

.github/workflows/scripts/e2e/gmc_install.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/e2e/gmc_install.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhlsunshine zhlsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/scripts/e2e/gmc_install.sh Outdated Show resolved Hide resolved
@daisy-ycguo
Copy link
Collaborator Author

Updated according to all the comments. And test passed: https://github.com/opea-project/GenAIInfra/actions/runs/9805546047

@zhlsunshine zhlsunshine merged commit af2d0f5 into opea-project:main Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable GMC installed in CI Xeon/Gaudi K8s cluster in opea-system namespace
3 participants