Set model-volume default to tmp volume #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we change the |
Set default value for model-volume to tmp volume. Change modelUsePV to modelUsePVC as this is PVC. Make modelUsePVC high priority than modelUseHostPath. Signed-off-by: Dolpher Du <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value for model-volume to tmp volume.
Change modelUsePV to modelUsePVC as this is PVC.
Make modelUsePVC high priority than modelUseHostPath.
Description
Minor fixes to PVC setting
Issues
#128
Type of change
List the type of change like below. Please delete options that are not relevant.
Tests
Try with different settings and check the volume:
helm install tgi tgi --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN}
helm install tgi tgi --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set global.modelUsePVC=model-volume
helm install tgi tgi --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set global.modelUseHostPath=/mnt/models
helm install tgiboth tgi --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set global.modelUseHostPath=/mnt/models --set global.modelUsePVC=model-volume