helm-chart/data-prep: Add the missing config for dataprep-redis #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
reviewed
Sep 2, 2024
There are some config missing but required by get_file/delete_file API, add them for functional usage. Please refer to the following link: https://github.com/opea-project/GenAIComps/blob/\ 84a7e573b88eed6d263b3ba164361ea06fccc46d/comps/dataprep/redis/\ langchain/config.py#L60 Signed-off-by: Cathy Zhang <[email protected]>
bjzhjing
force-pushed
the
Add-missing-config-dataprep-redis
branch
from
31ae40c
to
41053a8
Compare
lianhao
approved these changes
Sep 3, 2024
yongfengdu
approved these changes
Sep 3, 2024
Yugar-1
pushed a commit
to Yugar-1/GenAIInfra
that referenced
this pull request
Sep 5, 2024
…-project#374) There are some config missing but required by get_file/delete_file API, add them for functional usage. Please refer to the following link: https://github.com/opea-project/GenAIComps/blob/\ 84a7e573b88eed6d263b3ba164361ea06fccc46d/comps/dataprep/redis/\ langchain/config.py#L60 Signed-off-by: Cathy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some config missing but required by get_file/delete_file API, add them for functional usage.
To fix #373