helm chart: add nginx to avoid CORS issue #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
reviewed
Sep 3, 2024
Ruoyu-y
force-pushed
the
add_nginx
branch
13 times, most recently
from
923bf7d
to
a31911a
Compare
yongfengdu
approved these changes
Sep 5, 2024
Ruoyu-y
force-pushed
the
add_nginx
branch
5 times, most recently
from
f62662d
to
5e85296
Compare
|
Why this doesn't trigger helm CI test? |
Now is triggered, right? |
|
@Ruoyu-y please fix the helm chatqna-ui test failure |
Signed-off-by: Ruoyu Ying <[email protected]>
for more information, see https://pre-commit.ci
lianhao
approved these changes
Sep 9, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid CORS issue, add nginx within the helm chart based pipeline.
Issues
#368
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/aTests
n/a