-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Helm Chart for VideoQnA Application #497
base: main
Are you sure you want to change the base?
Changes from all commits
131861f
7cd488a
1f121e9
418edb7
24b4e3f
880e406
0110b85
56afc63
1a5f762
5fbfe85
3bb015d
a29691b
e8f58bb
a8cbdbf
63bf7f6
cf4360f
2d02cf9
d03a52f
1e5eea1
6e832ea
fc17e30
5ee3dc0
ea180a5
ef695c8
7be67a1
3cf4f29
0e37189
d13bdcb
c932c31
a993f1a
773922e
4bd8b04
91f96ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"spellright.language": ["en"], | ||
"spellright.documentTypes": ["markdown", "latex", "plaintext", "yaml"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Copyright (C) 2024 Intel Corporation | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
vdms-vector-db: | ||
enabled: true | ||
|
||
image: | ||
repository: opea/dataprep-multimodal-vdms | ||
pullPolicy: IfNotPresent | ||
# Overrides the image tag whose default is the chart appVersion. | ||
tag: "latest" | ||
|
||
INDEX_NAME: "mega-videoqna" | ||
vdmsHost: "" | ||
vdmsPort: "8001" | ||
entryCommand: ["/bin/sh"] | ||
extraArgs: ["-c", "sleep 15 && python ingest_videos.py"] | ||
yongfengdu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Set cacheUseHostPath to for caching encoding/embedding models and other related data | ||
global: | ||
cacheUseHostPath: "" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,11 +41,28 @@ spec: | |
{{- toYaml .Values.securityContext | nindent 12 }} | ||
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | ||
imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
{{- if .Values.entryCommand }} | ||
command: {{ .Values.entryCommand }} | ||
{{- end }} | ||
{{- if .Values.extraArgs }} | ||
args: | ||
{{- range .Values.extraArgs }} | ||
- {{ . | quote }} | ||
{{- end }} | ||
{{- end }} | ||
ports: | ||
- name: data-prep | ||
containerPort: {{ .Values.port }} | ||
containerPort: {{ .Values.service.containerPort }} | ||
protocol: TCP | ||
volumeMounts: | ||
{{- if .Values.global.modelUseHostPath }} | ||
- mountPath: /home/user/.cache/clip | ||
yongfengdu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: model-volume | ||
subPath: clip | ||
- mountPath: /home/user/.cache/huggingface/hub | ||
yongfengdu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: model-volume | ||
subPath: huggingface/hub | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When using model-volume, the subPath is not necessary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree, not necessary. But I suppose, as same volume is being re-used to mount different paths from different pod/containers, having a subPath helps to have a proper directory hierarchy inside model-volume and helps with what is coming from which container path instead of dumping everything in the root of model-volume. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The model-volume was used to save the models downloaded from huggingface hub, which is the HUGGINGFACE_HUB_CACHE here https://huggingface.co/docs/text-generation-inference/en/reference/launcher#huggingfacehubcache |
||
{{- end }} | ||
- mountPath: /tmp | ||
name: tmp | ||
{{- if .Values.livenessProbe }} | ||
|
@@ -63,6 +80,16 @@ spec: | |
resources: | ||
{{- toYaml .Values.resources | nindent 12 }} | ||
volumes: | ||
{{- if .Values.global.modelUseHostPath }} | ||
- name: model-volume | ||
hostPath: | ||
path: {{ .Values.global.modelUseHostPath }} | ||
type: Directory | ||
{{- else if .Values.global.modelUsePVC }} | ||
- name: model-volume | ||
persistentVolumeClaim: | ||
claimName: {{ .Values.global.modelUsePVC }} | ||
{{- end }} | ||
- name: tmp | ||
emptyDir: {} | ||
{{- with .Values.nodeSelector }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Copyright (C) 2024 Intel Corporation | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
image: | ||
repository: opea/dataprep-multimodal-vdms | ||
pullPolicy: IfNotPresent | ||
# Overrides the image tag whose default is the chart appVersion. | ||
tag: "latest" | ||
|
||
INDEX_NAME: "mega-videoqna" | ||
vdmsHost: "" | ||
vdmsPort: "8001" | ||
entryCommand: ["/bin/sh"] | ||
extraArgs: ["-c", "sleep 15 && python ingest_videos.py"] | ||
|
||
# Set cacheUseHostPath to for caching encoding/embedding models and other related data | ||
global: | ||
modelUseHostPath: "" | ||
modelUsePVC: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be better for this sample video to live in some common VidoQnA directory versus in docker_compose/intel/cpu/xeon/data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose requested change needs a PR in GenAIExamples rather than here.