Enable golang e2e test in CI #85
Conversation
daisy-ycguo
force-pushed
the
goe2e
branch
5 times, most recently
from
c4bdcf8
to
e0ad722
Compare
Signed-off-by: Yingchun Guo <[email protected]>
|
@irisdingbj If you want to add e2e tests for microservices-connector, please follow my guidance in scripts/e2e/go-test.sh and add your logic in three functions |
|
|
||
| jobs: | ||
| go-e2e: | ||
| runs-on: k8s |
There was a problem hiding this comment.
Thanks for the support for gmc e2e. Since we need support Gaudi as well, possible to make this runner setting as an Env Var? then in the gmc test script we can leverage this env var to select and deploy related manifests.
| - name: Install modules | ||
| run: | | ||
| echo "should_cleanup=true" >> $GITHUB_ENV | ||
| .github/workflows/scripts/e2e/go_test.sh install_gmc |
There was a problem hiding this comment.
Can we use separate script for different go project? In this case, CI can be clear which part fails. Based on that, I will prefer naming it as gmc_test.sh. Thoughts?
|
Thanks for the support! Let's merge this first and we can address the env var and filename in follow up PR. |
Description
Enable golang e2e test in CI
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
CI test