Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency with dangling commas #317

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix inconsistency with dangling commas #317

merged 1 commit into from
Apr 25, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Apr 25, 2022

Fixes inconsistency with dangling commas via eslint (sometimes dangling commas where there, sometimes not).

Now submitted in a separate PR as discussed in #307.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.701% when pulling 89bb235 on paescuj:dangling-commas into 1646515 on open-cli-tools:master.

gustavohenke
gustavohenke approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@gustavohenke gustavohenke merged commit 39fddef into open-cli-tools:master Apr 25, 2022
@paescuj paescuj deleted the dangling-commas branch April 26, 2022 05:39
@paescuj
Copy link
Collaborator Author

paescuj commented Apr 26, 2022

thank you!

You're very welcome!

@abdulrahman305 abdulrahman305 mentioned this pull request Jul 26, 2024
Open
@mun1013 mun1013 mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paescuj @coveralls @gustavohenke