New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onFinish signature when using exactOptionalPropertyTypes #372

Merged

gustavohenke merged 1 commit into open-cli-tools:main from Baune8D:fix-handle-return-signature

Oct 15, 2022

Contributor

Baune8D commented Oct 12, 2022

Seeing this error:

When consuming concurrently in a project with exactOptionalPropertyTypes enabled.


          Fix onFinish signature when using exactOptionalPropertyTypes

20c16bb

coveralls commented Oct 12, 2022

Coverage remained the same at 100.0% when pulling 20c16bb on Baune8D:fix-handle-return-signature into 54b56c6 on open-cli-tools:main.

Collaborator

paescuj commented Oct 13, 2022

Thanks @Baune8D! I'm going to take a look at this soon.

(Note to myself: Enable "strict" mode)

Contributor Author

Baune8D commented Oct 13, 2022 •

edited

Loading

No problem 🙂

FYI exactOptionalPropertyTypes is not included when using strict mode, it's a seperate property: https://www.typescriptlang.org/tsconfig#exactOptionalPropertyTypes

paescuj self-requested a review

October 13, 2022 15:38

paescuj self-assigned this

gustavohenke approved these changes

View reviewed changes

gustavohenke merged commit 7c8e644 into open-cli-tools:main

Member

gustavohenke commented Oct 15, 2022

(Note to myself: Enable "strict" mode)

@paescuj taking care of enabling strict as a starter 🙂

gustavohenke mentioned this pull request

Enable TypeScript strict mode #374

Merged

Member

gustavohenke commented Oct 22, 2022

Published in v7.5.0!

renovate bot referenced this pull request in fwouts/previewjs


          chore(deps): update dependency concurrently to ^7.5.0 (#1127)

1ef2cee

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`^7.4.0` ->
`^7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/296](https://togithub.com/open-cli-tools/concurrently/pull/296)
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[https://github.com/open-cli-tools/concurrently/pull/372](https://togithub.com/open-cli-tools/concurrently/pull/372)

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot referenced this pull request in zarf-dev/zarf


          Update dependency concurrently to v7.5.0 (#937)

5e352b2

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.4.0` ->
`7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/296](https://togithub.com/open-cli-tools/concurrently/pull/296)
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[https://github.com/open-cli-tools/concurrently/pull/372](https://togithub.com/open-cli-tools/concurrently/pull/372)

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Noxsios referenced this pull request in zarf-dev/zarf


          Update dependency concurrently to v7.5.0 (#937)

55f58e8

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.4.0` ->
`7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/296](https://togithub.com/open-cli-tools/concurrently/pull/296)
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[https://github.com/open-cli-tools/concurrently/pull/372](https://togithub.com/open-cli-tools/concurrently/pull/372)

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Leo1312424 mentioned this pull request

[Snyk] Upgrade concurrently from 7.5.0 to 7.6.0 Leo1312424/HackMe#4

Open

WontonSam mentioned this pull request

[Snyk] Upgrade concurrently from 6.5.1 to 8.2.2 WontonSam/shopify#37

Open

abdulrahman305 mentioned this pull request

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 abdulrahman305/aws-sdk-js-v3#1

Open

mun1013 mentioned this pull request

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 mun1013/taxiApp-react-typescript#2

Open

Mark-hub-2323 mentioned this pull request

[Snyk] Upgrade concurrently from 5.3.0 to 8.2.2 Mark-hub-2323/juice-shop#11

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet