-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use enum for dependency compliance #49
Use enum for dependency compliance #49
Conversation
/hold @willkutler did you also set the kubebuilder markers in the config-policy-controller? |
@willkutler, I also noticed the enum is different here: This should likely be updated with this change as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @mprahl that the propagator probably needs an update in tandem with this PR.
It looks like open-cluster-management-io/governance-policy-propagator#59 updated the ComplianceState
, but the Dependency structs use a string type for its Compliance
field instead of the ComplianceState
struct:
@willkutler could you please squash your commits? |
Signed-off-by: Will Kutler <[email protected]>
f720e44
to
1184b85
Compare
@mprahl is this good to go? |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl, willkutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New linting changes are required for go 1.18 Signed-off-by: Gus Parvin <[email protected]>
Adds an enum for
dependencies[].compliance
andextraDependencies[].compliance
to block creation of policies with that field set incorrectly. This will fix policies creating with invalid dependencies.refs: