Fix template sync set to Nomcompliant when context cancel #127
Conversation
| @@ -213,3 +223,143 @@ func TestHasDuplicateNames(t *testing.T) { | |||
| t.Fatal("Duplicate name not detected") | |||
| } | |||
| } | |||
|
|
|||
| func TestContextCancel(t *testing.T) { | |||
There was a problem hiding this comment.
A Simple workaround but Not a simple test. Do we need this?
There was a problem hiding this comment.
Are you asking if we need the test?
There was a problem hiding this comment.
I think the test is a bit much for this, so I'm okay with removing it.
There was a problem hiding this comment.
This test cannot catcheObject, err := res.Get(ctx, tName, metav1.GetOptions{}) line 534 actually
There was a problem hiding this comment.
But I used this test to verify in my local. I could control the cancel ctx point
yiraeChristineKim
force-pushed
the
ACM-10402-ocm
branch
from
5d93ac0
to
a204d67
Compare
Bug: If the template-sync is shutting down and it's in the middle of a reconcile request, it can set the policy to noncompliant with this Ref: https://issues.redhat.com/browse/ACM-10402 Signed-off-by: Yi Rae Kim <[email protected]>
yiraeChristineKim
force-pushed
the
ACM-10402-ocm
branch
from
a204d67
to
e03eaaf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6a8baf3
into
open-cluster-management-io:main
Bug: If the template-sync is shutting down and it's in the middle of a reconcile request, it can set the policy to noncompliant with this
Ref: https://issues.redhat.com/browse/ACM-10402