Disable the Gatekeeper controller when run in old Kubernetes clusters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinKuli
reviewed
Mar 27, 2023
main.go
Outdated
Comment on lines
374
to
377
| discoveryClient := discovery.NewDiscoveryClientForConfigOrDie(managedCfg) | ||
|
|
||
| serverVersion, err := discoveryClient.ServerVersion() | ||
| if err != nil { |
There was a problem hiding this comment.
I took a quick look and I think this is true... this won't do an api-resources refresh or whatever, that could take a long time, right?
There was a problem hiding this comment.
Right, it just calls the /version HTTP endpoint on the Kubernetes API.
Relates: https://issues.redhat.com/browse/ACM-4588 Signed-off-by: mprahl <[email protected]>
Signed-off-by: mprahl <[email protected]>
JustinKuli
approved these changes
Mar 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates:
https://issues.redhat.com/browse/ACM-4588