Enable concurrent reconciles, QPS, and burst configurations #91
Conversation
main.go
Outdated
| hubCfg.QPS, hubCfg.Burst = tool.Options.ClientQPS, int(tool.Options.ClientBurst) | ||
| managedCfg.QPS, managedCfg.Burst = tool.Options.ClientQPS, int(tool.Options.ClientBurst) |
There was a problem hiding this comment.
Using multiple assignments like this is unusual. I'd prefer each to have their own line.
I also wonder if it would be nice to be able to independently configure the QPS and Burst for the hub cluster client and the managed cluster client. I can imagine that a user would increase these settings in order to speed things up on the managed cluster, but would not want to open up the possibility of a massively increased number of requests to their hub cluster. Maybe another reviewer can provide input - we also don't want to have too many configuration options, because they could get hard to manage.
To allow configuration for concurrent reconciles, QPS, and burst, the following changes are proposed: - Each reconciler struct for all controllers will require an extra field called 'ConcurrentReconciles`, which is exposed in main and set to the value specified in the arguments passed to the framework addon. - The `ConcurrentReconcile` field will be used when the set up between controller and manager occurs - QPS and burst are also parsed from controller arguments passed to the framework addon, and override default QPS and burst values from controller-runtime after the hub and managed configs are created. ref: https://issues.redhat.com/browse/ACM-6711 Signed-off-by: Jason Zhang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 3ccb6f2
into
open-cluster-management-io:main
To allow configuration for concurrent reconciles, QPS, and burst, the following changes are proposed:
ConcurrentReconciles, which is exposed in main and set to the value specified in the arguments passed to the framework addon.ConcurrentReconcilefield will be used when the set up between controller and manager occursref: https://issues.redhat.com/browse/ACM-6711