fix nil reference when hub-only controllers are disabled #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --disable-spec-sync is set to true, the hub manager is set to nil. Currently, this is not detected when setting up the controllers, which causes a seg fault when referencing the nil hub manager. In addition to fixing the behaviour, a new cache will be created on the hub for the case where the hub manager, and subsequently, the related hub manager cache, is not set. ref: https://issues.redhat.com/browse/ACM-6869 Signed-off-by: Jason Zhang <[email protected]>
yiraeChristineKim
approved these changes
Nov 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yiraeChristineKim, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0ac24d0
into
open-cluster-management-io:main
4 checks passed
zyjjay
added a commit
to zyjjay/governance-policy-framework-addon
that referenced
this pull request
Nov 23, 2023
…isabled ref: https://issues.redhat.com/browse/ACM-6869 Cherry-pick: - open-cluster-management-io#98 (comment) Closes: stolostron#216 Signed-off-by: Jason Zhang <[email protected]>
zyjjay
added a commit
to zyjjay/governance-policy-framework-addon
that referenced
this pull request
Nov 23, 2023
…isabled ref: https://issues.redhat.com/browse/ACM-6869 Cherry-pick: - open-cluster-management-io#98 (comment) Closes: stolostron#216 Signed-off-by: Jason Zhang <[email protected]>
zyjjay
added a commit
to zyjjay/governance-policy-framework-addon
that referenced
this pull request
Nov 23, 2023
…isabled ref: https://issues.redhat.com/browse/ACM-6869 Cherry-pick: - open-cluster-management-io#98 (comment) Closes: stolostron#216 Signed-off-by: Jason Zhang <[email protected]>
zyjjay
added a commit
to zyjjay/governance-policy-framework-addon
that referenced
this pull request
Nov 23, 2023
…isabled ref: https://issues.redhat.com/browse/ACM-6869 Cherry-pick: - open-cluster-management-io#98 (comment) Closes: stolostron#216 Signed-off-by: Jason Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --disable-spec-sync is set to true, the hub manager is set to nil. Currently, this is not detected when setting up the controllers, which causes a seg fault when referencing the nil hub manager. In addition to fixing the behaviour, a new cache will be created on the hub for the case where the hub manager, and subsequently, the related hub manager cache, is not set.
ref: https://issues.redhat.com/browse/ACM-6869