Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension_explorer/templates/publishers.html: Integrate content from … #84

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

duncandewhurst
Copy link
Contributor

…extension template

Related to open-contracting/standard_extension_template#37

After merging, need to remove content from standard extension template readme.

@jpmckinney
Copy link
Member

Just checking what makes this PR a draft?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9989097653

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.806%

Totals Coverage Status
Change from base Build 9584945633: 0.0%
Covered Lines: 434
Relevant Lines: 453

💛 - Coveralls

@duncandewhurst
Copy link
Contributor Author

Oops, I somehow missed the notification about your comment. Sorry!

It was draft because I needed to resolve the pytest failure. I've done that now.

As well as integrating the content from how the extensions work I think that we should also integrate the content from codelists. Otherwise, the explanations of schema extensions and codelist extensions will be in different places. I've rewritten the codelist explanation to follow the same style as the schema guidance:

An extension's codelist CSV files follow the structure of the OCDS codelist files and describe new codelists and codes. To add a new codelist, ensure that your filename does not clash with any existing codelist filenames. To add codes to an existing codelist, name your file +<codelist filename>.csv and ensure that the new codes do not clash with any existing codes. For example, to add 'subcontractor' to partyRole.csv, add a file named +partyRole.csv to the codelists directory and set its content to:

Code,Title,Description
subcontractor,Subcontractor,An organization that will perform part of a contract on behalf of a supplier.

Shall I add that to this PR?

@duncandewhurst
Copy link
Contributor Author

Oh, I forgot that open-contracting/standard_extension_template#41 is about moving all the content. I may as well do it all in this PR, but I'll prepare a draft in Google Docs before updating the HTML templates.

@duncandewhurst
Copy link
Contributor Author

Work in progress content

@duncandewhurst
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants