Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer 0.1 #1302

Merged
merged 20 commits into from
Jul 31, 2021
Merged

Primer 0.1 #1302

merged 20 commits into from
Jul 31, 2021

Conversation

EricReese15
Copy link
Contributor

@EricReese15 EricReese15 commented May 31, 2021

Fully updated primer based on user and Helpdesk feedback

closes #1239, closes #614

@jpmckinney jpmckinney mentioned this pull request Jul 26, 2021
- getting_started/index: Replace with primer/index
- getting_started/use_cases: Move to guidance/design/user_needs. Add link on guidance/design.
- getting_started/contracting_process: Replace with primer/how. Update text on guidance/build. Worked example at schema/identifiers.
- getting_started/building_blocks: Remove. Repeats information on schema/reference and primer/how. (Might restore some elements.)
- getting_started/releases_and_records: Replace with primer/releases_and_records. (Might restore some elements.)
- getting_started/publication_patterns: Remove. Packaging is de-emphasized in 1.2. "Bulk and individual files" at guidance/build/hosting and primer/releases_and_records.
- getting_started/validation: Remove. Repeats information in guidance/build (validation, conformance) and guidance/publish/quality (completeness, utility). Add reason to use the Data Review tool to guidance/build.
- getting_started/quality: Move to guidance/publish/quality. Add section to guidance/publish.
- Update internal links based on above chnges
- make pdf: Add new and missing pages
@jpmckinney
Copy link
Member

We need to decide what (if anything) to retain from these pages (if retained, need to add to Guidance):

@yolile What do you think?

I'm not sure if/where to re-integrate the OCDS example:

```{jsoninclude} ../examples/contract.json
:jsonpointer: /releases
:expand: releases, tender, awards, contracts, period, value, items, tag, parties, documents
```

@jpmckinney
Copy link
Member

Preview should be available here if build succeeds: https://standard.open-contracting.org/staging/primer_0.1/en/primer/

@yolile
Copy link
Member

yolile commented Jul 26, 2021

For https://standard.open-contracting.org/1.1/en/getting_started/building_blocks/:

For https://standard.open-contracting.org/1.1/en/getting_started/releases_and_records/:

@jpmckinney
Copy link
Member

jpmckinney commented Jul 27, 2021

Thanks! I’ll move those to new pages. Can you review the rest of the PR in the meantime?

@yolile
Copy link
Member

yolile commented Jul 27, 2021

Can you review the ready of the PR in the meantime?

Sure, I will!

@jpmckinney
Copy link
Member

For https://standard.open-contracting.org/1.1/en/getting_started/building_blocks/:

I don't think this example does much more than the example in https://www.open-contracting.org/resources/ocds-1-1-codelist-mapping-template-guidance/, which is what we want people to use for mapping codelists. What do you think?

When preparing the Primer, Eric and I were not sure that the metaphor of "building blocks" was actually very helpful.

  • We might not preserve common definitions for items, etc., because extending them can have unintended consequences Guidance around extending subschema (building blocks) #606, in which case we will not have "building blocks" in the same way.
  • It's not clear that it is especially relevant for an implementer to learn that some objects follow the same schema in different parts of the data. It seems okay to learn this in the schema reference.
  • I created Eliminate language of "building blocks" #1347 about changing the terminology.

So, I'm okay with not having this section. What do you think?

I'll create an issue to add example data to the schema reference, since that is the main benefit of this section. #1348

For https://standard.open-contracting.org/1.1/en/getting_started/releases_and_records/:

The old page says very little about packages (only mentioning the uri metadata). Since packages are going to become optional #1084, it is not important to mention them in the Primer.

Do you mean the two Example and Hint boxes? Isn't the Example covered by: https://standard.open-contracting.org/1.1/en/guidance/build/change_history/

For the Hint, it is a useful demonstration of the value of compiled releases. However, we know that publishers are unlikely to correctly implement the merging behavior (it's quite easy to have bugs), and we know that very few publishers offer compiled releases anyway (unless they do "easy releases"). So, I think we've accepted that the registry is the way for users to access compiled releases.

@yolile
Copy link
Member

yolile commented Jul 28, 2021

I don't think this example does much more than the example in https://www.open-contracting.org/resources/ocds-1-1-codelist-mapping-template-guidance/, which is what we want people to use for mapping codelists. What do you think?

True, I found this mapping a local codelist worked example outline, which means that at some point we thought that it would be useful to have that worked example, I guess. (see also the worked examples spreadseet)

It's not clear that it is especially relevant for an implementer to learn that some objects follow the same schema in different parts of the data. It seems okay to learn this in the schema reference.

Yes, actually, I think that it is more relevant for them to learn about that while developing an extension, for example, which is something more advance and requires understanding/looking at the schema reference, so I'm ok with not having this section too. (fun fact: I've never managed to found a correct/nice/perfect translation for this in Spanish, so I'm happy in that sense too)

Since packages are going to become optional #1084, it is not important to mention them in the Primer.

That is what I thought, all good then.

Do you mean the two Example and Hint boxes? Isn't the Example covered by: https://standard.open-contracting.org/1.1/en/guidance/build/change_history/

It is partially covered, the https://standard.open-contracting.org/1.1/en/getting_started/releases_and_records/#repeating-previous-information section is not covered and I think that it contains useful guidance about minimal updates (recently one data user referenced this section of the documentation, so at least it is useful for some people)
And for compile releases and easy releases, maybe we can add a reference to the easy releases guidance in https://standard.open-contracting.org/1.1/en/guidance/build/change_history/?

@jpmckinney
Copy link
Member

Agreed on a call to:

  • Update the codelist mapping template guidance with a better example, rather than have guidance in both the template's guidance and in the docs. Tracked in CRM-7491
  • Create an issue to re-introduce a worked example for minimal updates and change history Example: Minimal updates in change history #1364

And in this PR, to:

  • Link to easy_releases from change_history, for guidance on setting the release id 2d0b9c6

@jpmckinney jpmckinney merged commit 9864089 into 1.1-dev Jul 31, 2021
@jpmckinney jpmckinney deleted the primer_0.1 branch July 31, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Draft Primer to replace Getting Started section of documentation Reword use cases page
3 participants