Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated fields from examples #1390

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Aug 20, 2021

The deprecated fields are:

  • countryName: field renamed to country, and value changed to ISO code
  • submissionMethod: removed
  • eligibilityCriteria: removed
  • packages: removed

None of the deprecated codes ('funder') were used in examples (except in the deprecated submissionMethod field).

This PR leaves a submissionMethod in getting_started/building_blocks.md, but this is gone in the Primer, once I merge 1.1-dev.

@jpmckinney jpmckinney changed the base branch from 1.1-dev to 1.2-dev August 20, 2021 19:15
@jpmckinney jpmckinney requested a review from yolile August 20, 2021 19:15
@jpmckinney jpmckinney changed the title remove deprecated fields and codes from examples Remove deprecated fields and codes from examples Aug 20, 2021
@jpmckinney jpmckinney changed the title Remove deprecated fields and codes from examples Remove deprecated fields from examples Aug 20, 2021
@jpmckinney jpmckinney force-pushed the remove-deprecated-fields-and-codes-from-examples branch from 54be86c to 9e204b0 Compare August 20, 2021 19:57
@yolile yolile merged commit 091e41e into 1.2-dev Aug 24, 2021
@yolile yolile deleted the remove-deprecated-fields-and-codes-from-examples branch August 24, 2021 21:21
@jpmckinney jpmckinney added this to the 1.2.0 milestone Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants