Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link object to schema reference #1431

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Conversation

duncandewhurst
Copy link
Contributor

Closes #928

@duncandewhurst duncandewhurst added this to the 1.2.0 milestone Oct 14, 2021
@duncandewhurst duncandewhurst changed the base branch from 1.1-dev to 1.2-dev October 14, 2021 22:21
Copy link
Contributor

@mrshll1001 mrshll1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I think it might be worthwhile emphasising the word "same" in italics, though.

docs/history/changelog.md Outdated Show resolved Hide resolved
docs/schema/reference.md Outdated Show resolved Hide resolved
docs/schema/reference.md Outdated Show resolved Hide resolved
docs/schema/reference.md Outdated Show resolved Hide resolved
@jpmckinney jpmckinney added the unresolved-suggestions To filter pull requests with unresolved suggestions label Oct 18, 2021
@duncandewhurst duncandewhurst requested review from jpmckinney and removed request for odscrachel October 19, 2021 02:11
@yolile yolile removed the unresolved-suggestions To filter pull requests with unresolved suggestions label Nov 12, 2021
@jpmckinney jpmckinney merged commit 6462ea0 into 1.2-dev Nov 30, 2021
@jpmckinney jpmckinney deleted the 928-add-link-reference branch November 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add links field
4 participants