Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for Zambian Kwacha #562

Closed
wants to merge 3 commits into from

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Sep 5, 2017

to reflect ISO4217:2015 - this code was updated effective 2013

closes #554

to reflect ISO4217:2015 - this code was updated effective 2013
@jpmckinney
Copy link
Member

@duncandewhurst Can you add a note to the changelog?

@Bjwebb
Copy link
Contributor

Bjwebb commented Sep 27, 2017

There's other changes that are missing e.g. https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_161.pdf

Also, shouldn't our codelist contain all historic values, to support historic data?

@jpmckinney
Copy link
Member

Can we have a script to generate the codelist?

For historic values, would we list them as deprecated?

@jpmckinney
Copy link
Member

Also, don't we need to update release-schema.json?

@Bjwebb
Copy link
Contributor

Bjwebb commented Oct 24, 2017

I've worked on a script to generate the codelist. There's a new pull request for this #607, so closing this PR as superseded by that one.

@Bjwebb Bjwebb closed this Oct 24, 2017
@jpmckinney jpmckinney deleted the currency-codelist-update branch October 24, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

currency: Incorrect code for Zambian currency
3 participants