-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BB-9078] Styling fix #68
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## asu-moe/redwood-css #68 +/- ##
=======================================================
+ Coverage 92.54% 92.61% +0.07%
=======================================================
Files 706 706
Lines 12515 12542 +27
Branches 2728 2737 +9
=======================================================
+ Hits 11582 11616 +34
+ Misses 898 891 -7
Partials 35 35 ☔ View full report in Codecov by Sentry. |
@@ -5,7 +5,7 @@ | |||
.item-card-header__title-btn { | |||
justify-content: flex-start; | |||
padding: 0; | |||
width: fit-content; | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this solves the issue at hand, it does make the edit button as well as the Draft (Unpub..)
tag look quite odd and squished
I would suggest the following changes which seems to solve our problem without affecting other elements:
width: 100%; | |
width: fit-content; | |
max-width: 62%; |
What do you think ? cc. @0x29a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaustavb12 I'm not sure that's going to work. With width: fit-content
the truncated line gets wrapped which was the original issue. Maybe we can play around with max-width while keeping width: 100%
but it feels like that's still going to throw off the styling one way or the other. The oc instance studio seems to be down at the moment. Will test it once it's up and running and update.
95cc92b
to
36babc8
Compare
36babc8
to
b6b246c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Tested in local
- I read through the code
Co-authored-by: Kaustav Banerjee <[email protected]>
02d479f
to
8da960a
Compare
This PR fixes the styling for long titles that should be truncated.