Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.1.3, automatic PyPI uploads #199

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

jmbowman
Copy link
Contributor

This bumps the version and attempts to set up automated PyPI uploads via CircleCI following the advice in their blog post on the topic:

  • Removed an obsolete pin on an old version of setuptools (the referenced bug was long since fixed)
  • Added a deployment job.
  • Only run the deployment job for git tag pushes, and only if the build job for the same push succeeds.

Before the automatic uploads will work, you need to add the PYPI_PASSWORD environment variable to the CircleCI settings, as explained here ("the Environment Variables page of the Build > Project > Settings in the CircleCI application"). This should be the PyPI password of the opencraft account.

It used to be necessary to manually register a package on PyPI before uploading the first release, but it looks like with the switch to Warehouse this is no longer needed.

@jmbowman
Copy link
Contributor Author

@bradenmacdonald Here's the version bump and auto-upload attempt; if it looks ok, please go ahead and trigger a build to make sure I didn't break anything in the CircleCI configuration. I noticed that the last master build failed attempting to download Firefox, but the file still seems to be there so I'm hoping that was just a temporary Sourceforge outage.

Copy link
Member

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 👍

  • I tested this: I guess I can't test this until I merge + tag a release, so I will test it post-merge.
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation - No but I can quickly add something to the readme in a separate PR if this works.

@bradenmacdonald bradenmacdonald merged commit ec20caf into open-craft:master Jul 2, 2018
@bradenmacdonald
Copy link
Member

@bradenmacdonald
Copy link
Member

BTW, I'm assuming there's no issue with the PyPI package name (xblock-problem-builder) being different from the repo name (problem-builder) and the package name (problem_builder) ?

@jmbowman
Copy link
Contributor Author

jmbowman commented Jul 2, 2018

Correct, the name of the package on PyPI is purely determined by the name field in setup.py, and often differs from those other characteristics of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants