Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disabling deck validation with ALL_CARDS_AVAILABLE #268

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

willroberts
Copy link
Collaborator

@willroberts willroberts commented Jan 17, 2023

Summary

Describe your changes here. Remove any inapplicable sections.

App changes (app/, etc.):

  • Replaces ALL_CARDS_AVAILABLE flag usage with DISABLE_DECK_VALIDATION flag in deck validation code

Server changes (config/, server/, worker/, etc.):

  • Adds DISABLE_DECK_VALIDATION flag
  • Removes unused PayPal/Mailchimp flags

Testing

Have you have tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant