Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes duplicated import/export feature #270

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

willroberts
Copy link
Collaborator

@willroberts willroberts commented Jan 18, 2023

Summary

This was added in #237, but it turns out there was already import/export code available in the client. You have to create or edit a deck before the UI appears. It also uses a different format (base64-encoded CSV instead of JSON), and only operates on one deck at a time. However, since that is the existing mechanism, many third-party sites provide this format of deck codes. Let's remove the extraneous version added recently, and standardize on the existing version.

App changes (app/, etc.):

  • Removes extraneous import/export UI and handlers

Server changes (config/, server/, worker/, etc.):

  • Removes extraneous import/export routes and helpers

Testing

Have you have tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

@willroberts willroberts merged commit 31e2770 into main Jan 18, 2023
@willroberts willroberts deleted the remove-dupe-import-export branch January 18, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant