Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract contrib workgroups from sdks #221

Closed
wants to merge 1 commit into from

Conversation

toddbaert
Copy link
Member

The TC agreed that we need to add CODEOWNERs in each contrib repo (see doc here), which will denote who is responsible for every component therein and make them required reviewers for PRs that impact their component.

To be a CODEOWNER, one must have write permissions to the repo in question (this is a requirement of github). Due to this, it's necessary to separate SDK permissions from contrib permissions.

This PR does that. No net permissions changes are represented here, but as CODEOWNERS are identified, we will add maintainers to the contrib-{intert-lang-here} workgroups so that they can be notified of issues/PRs pertaining to their components.

@toddbaert toddbaert force-pushed the chore/extract-contrib-workgroups branch 2 times, most recently from d8845d9 to 2b45bd1 Compare July 5, 2023 19:26
@toddbaert toddbaert force-pushed the chore/extract-contrib-workgroups branch from 2b45bd1 to faf5183 Compare July 5, 2023 19:27
@toddbaert
Copy link
Member Author

toddbaert commented Jul 5, 2023

@aepfli the CI test seems to be failing b/c the newly referenced teams don't exist. I guess the check assumes they do? Or have I done something wrong?

@thomaspoignant
Copy link
Member

Just to be 100% sure you will add maintainer in another PR ?
Because I maintain some providers in some contrib repos (dotnet, js) and I am not listed as maintainer.

@toddbaert
Copy link
Member Author

Just to be 100% sure you will add maintainer in another PR ? Because I maintain some providers in some contrib repos (dotnet, js) and I am not listed as maintainer.

Ya that was the intent. I have to look back in history in each repo to get the owners. I plan on doing that.

@toddbaert
Copy link
Member Author

Putting this in draft pending this conversation.

@toddbaert toddbaert marked this pull request as draft July 5, 2023 21:40
@aepfli
Copy link
Member

aepfli commented Jul 6, 2023

@aepfli the CI test seems to be failing b/c the newly referenced teams don't exist. I guess the check assumes they do? Or have I done something wrong?

well sadly this is a chicken egg problem - peribolos complains because the groups do not exists, which will not be created during a dry run :(

@toddbaert
Copy link
Member Author

@aepfli the CI test seems to be failing b/c the newly referenced teams don't exist. I guess the check assumes they do? Or have I done something wrong?

well sadly this is a chicken egg problem - peribolos complains because the groups do not exists, which will not be created during a dry run :(

I imagined that was the problem! We can force this one in if need be.

@toddbaert
Copy link
Member Author

Closing this PR, we are now using this action to solve the same problem without requiring write permissions.

@toddbaert toddbaert closed this Jul 12, 2023
@toddbaert toddbaert deleted the chore/extract-contrib-workgroups branch July 12, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants