-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extract contrib workgroups from sdks #221
Conversation
d8845d9
to
2b45bd1
Compare
Signed-off-by: Todd Baert <[email protected]>
2b45bd1
to
faf5183
Compare
@aepfli the CI test seems to be failing b/c the newly referenced teams don't exist. I guess the check assumes they do? Or have I done something wrong? |
Just to be 100% sure you will add maintainer in another PR ? |
Ya that was the intent. I have to look back in history in each repo to get the owners. I plan on doing that. |
Putting this in draft pending this conversation. |
well sadly this is a chicken egg problem - peribolos complains because the groups do not exists, which will not be created during a dry run :( |
I imagined that was the problem! We can force this one in if need be. |
Closing this PR, we are now using this action to solve the same problem without requiring write permissions. |
The TC agreed that we need to add CODEOWNERs in each contrib repo (see doc here), which will denote who is responsible for every component therein and make them required reviewers for PRs that impact their component.
To be a CODEOWNER, one must have write permissions to the repo in question (this is a requirement of github). Due to this, it's necessary to separate SDK permissions from contrib permissions.
This PR does that. No net permissions changes are represented here, but as CODEOWNERS are identified, we will add
maintainers
to thecontrib-{intert-lang-here}
workgroups so that they can be notified of issues/PRs pertaining to their components.