polishing tests + covering FlagDConfig

Signed-off-by: odubajDT <[email protected]>
open-feature · Apr 4, 2023 · a383a08 · a383a08
1 parent e152171
commit a383a08
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 10 deletions.
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdConfigTest.cs b/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdConfigTest.cs
@@ -61,12 +61,32 @@ public void TestFlagdConfigEnabledCacheApplyCacheSize()
             Assert.Equal(20, config.MaxCacheSize);
         }
 
+        [Fact]
+        public void TestFlagdConfigSetCertificatePath()
+        {
+            CleanEnvVars();
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvCertPart, "/cert/path");
+
+            var config = new FlagdConfig();
+
+            Assert.Equal("/cert/path", config.CertificatePath);
+            Assert.True(config.UseCertificate);
+
+            CleanEnvVars();
+
+            config = new FlagdConfig();
+
+            Assert.Equal("", config.CertificatePath);
+            Assert.False(config.UseCertificate);
+        }
+
         private void CleanEnvVars()
         {
             System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarTLS, "");
             System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarSocketPath, "");
             System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarCache, "");
             System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarMaxCacheSize, "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvCertPart, "");
         }
     }
 }
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs b/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs
@@ -18,25 +18,25 @@ public class UnitTestFlagdProvider
         public void BuildClientForPlatform_Should_Throw_Exception_When_FlagdCertPath_Not_Exists()
         {
             // Arrange
-            System.Environment.SetEnvironmentVariable("FLAGD_SERVER_CERT_PATH", "non-existing-path");
-            System.Environment.SetEnvironmentVariable("FLAGD_HOST", "localhost");
-            System.Environment.SetEnvironmentVariable("FLAGD_PORT", "5001");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvCertPart, "non-existing-path");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarHost, "localhost");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "5001");
 
             // Act & Assert
             Assert.Throws<ArgumentException>(() => new FlagdProvider());
 
             // Cleanup
-            System.Environment.SetEnvironmentVariable("FLAGD_SERVER_CERT_PATH", "");
-            System.Environment.SetEnvironmentVariable("FLAGD_HOST", "");
-            System.Environment.SetEnvironmentVariable("FLAGD_PORT", "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvCertPart, "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarHost, "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "");
         }
 
         [Fact]
         public void BuildClientForPlatform_Should_Return_Client_For_Non_Unix_Socket_Without_Certificate()
         {
             // Arrange
-            System.Environment.SetEnvironmentVariable("FLAGD_HOST", "localhost");
-            System.Environment.SetEnvironmentVariable("FLAGD_PORT", "5001");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarHost, "localhost");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "5001");
 
             // Act
             var flagdProvider = new FlagdProvider();
@@ -47,8 +47,8 @@ public void BuildClientForPlatform_Should_Return_Client_For_Non_Unix_Socket_With
             Assert.IsType<Service.ServiceClient>(client);
 
             // Cleanup
-            System.Environment.SetEnvironmentVariable("FLAGD_HOST", "");
-            System.Environment.SetEnvironmentVariable("FLAGD_PORT", "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarHost, "");
+            System.Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "");
         }
 
 #if NET462