Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reduce OTel dependencies #132

Merged
merged 2 commits into from
Jan 11, 2024
Merged

refactor: Reduce OTel dependencies #132

merged 2 commits into from
Jan 11, 2024

Commits on Jan 11, 2024

  1. refactor: Reduce OTel dependencies 

    The `OpenFeature.Contrib.Hooks.Otel` project currently references
(1) an exporter implementation which libraries should _not_ do
under any normal circumstances, and (2) the main OpenTelemetry
project which is excessive given all of the excellent work by
the dotnet/runtime and open-telemetry/opentelemetry-dotnet teams
have done over the last couple of years to ensure that the BCL
types in `System.Diagnostics` conform to OTel standards.

This commit removes (1) and pares down (2) to from `OpenTelemetry`
to `OpenTelemetry.Api` to shrink the dependency footprint we ship
to consumers.

At this point, I would argue that this hooks package should meet
the minimal dependency requirement for upstream inclusion in the
main OpenFeature package, but deferring that discussion for now.

Signed-off-by: Austin Drenski <[email protected]>
    @austindrenski
    austindrenski committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    26d42b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into reduce-otel-dependencies

    @toddbaert
    toddbaert authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    665bc9a View commit details
    Browse the repository at this point in the history