feat: GO Feature Flag dotnet provider #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
from
2da84e8
to
0aecc6b
Compare
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
from
e3b26e4
to
68f86ce
Compare
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
from
3ad016c
to
99a6db1
Compare
|
Thanks, as always, @thomaspoignant. @kinyoklion @benjiro please don't feel obligated to review this, but I've added you if you're interested. I'll be taking a look at it myself as well. |
toddbaert
reviewed
Nov 29, 2022
src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Nov 29, 2022
src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Nov 29, 2022
src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Nov 29, 2022
src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs
Outdated
Show resolved
Hide resolved
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
2 times, most recently
from
5ad4478
to
4fd777a
Compare
- Using better way to checks the options - Using string interpolation - Throw proper exception when we have parsing error. Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
from
4fd777a
to
ccf792a
Compare
thomaspoignant
requested review from
toddbaert
and removed request for
benjiro and
kinyoklion
|
I don't know why GitHub has removed @benjiro and @kinyoklion from this one when I have re-request the approval from @toddbaert 😞 |
toddbaert
requested review from
benjiro,
kinyoklion and
beeme1mr
and removed request for
kinyoklion
toddbaert
reviewed
Nov 30, 2022
src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Nov 30, 2022
test/OpenFeature.Contrib.Providers.GOFeatureFlag.Test/GoFeatureFlagProviderTest.cs
Outdated
Show resolved
Hide resolved
|
I think #24 (comment) is my only remaining concern. Unless you know for sure that there's no need to call |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
requested review from
toddbaert
and removed request for
benjiro and
beeme1mr
Signed-off-by: Thomas Poignant <[email protected]>
toddbaert
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Thanks @thomaspoignant ! I've approved!
If you could add just one more thing before merge: a small readme!
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
go-feature-flag-provider
branch
from
84a9eb4
to
ceb3665
Compare
@toddbaert I have added the README, I guess we are good to go. |
bacherfl
pushed a commit
to bacherfl/dotnet-sdk-contrib
that referenced
this pull request
Jan 31, 2023
GO Feature Flag dotnet provider Signed-off-by: Thomas Poignant <[email protected]>
vpetrusevici
pushed a commit
to vpetrusevici/open-feature-dotnet-sdk-contrib
that referenced
this pull request
Oct 18, 2023
GO Feature Flag dotnet provider Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Vladimir Petrusevici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new provider for GO Feature Flag.