Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flagd provider basic functionality #31
feat: flagd provider basic functionality #31
Changes from 6 commits
c092fa7
aa8b6ca
e95d27e
a4411fb
a8ec6f1
ff21785
b6cfdb1
56b44db
b45b250
c52f2b3
96e305c
f0cc7a0
9830a75
27f592f
8877ada
ade7d01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would simplify the logic here a bit just to throw an informative error (you still make need to set the correct error code). The SDK itself will always handle any errors by defaulting. The most straightforward thing for a provider to do is simply throw an error with the correct code. https://github.com/open-feature/dotnet-sdk/blob/main/src/OpenFeature/Error/FeatureProviderException.cs
https://docs.openfeature.dev/docs/reference/concepts/provider#how-should-i-handle-error-conditions
This will be slightly easier when this is done, but you can do it now by just setting the right error type on the existing generic error class.