Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flagsmith provider no key exception #98

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

vpetrusevici
Copy link
Contributor

This PR

  • fixed possible exception when targetKey was not set in context.

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: Vladimir Petrusevici <[email protected]>
@vpetrusevici vpetrusevici changed the title Fix Flagsmith provider no key exception fix: Flagsmith provider no key exception Nov 8, 2023
Signed-off-by: Vladimir Petrusevici <[email protected]>
@vpetrusevici
Copy link
Contributor Author

vpetrusevici commented Nov 10, 2023

@toddbaert Hi!
Can we complete this one?

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but please revert the version change because the release automation system will bump it automatically.

Signed-off-by: vpetrusevici <[email protected]>
@beeme1mr beeme1mr merged commit da84a17 into open-feature:main Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants