-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OpenFeature.Extensions.Hosting
package
#264
Comments
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, but tldr; libraries don't need the implementation package, so reduce to the abstractions package to remove transitive dependencies on: - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Options - (and a few others depending on the TFM) Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, but tldr; libraries don't need the implementation package, so reduce to the abstractions package to remove transitive dependencies on: - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Options - (and a few others depending on the TFM) Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, but tldr; libraries don't need the implementation package, so reduce to the abstractions package to remove transitive dependencies on: - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Options - (and a few others depending on the TFM) Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
This was referenced Jan 16, 2024
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
10 tasks
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 16, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 17, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 17, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 17, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 17, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 19, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 19, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
toddbaert
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 19, 2024
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 20, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 22, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 23, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 23, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 23, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 23, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 23, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 27, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 27, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 27, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
referenced
this issue
in austindrenski/open-feature-dotnet-sdk
Jan 29, 2024
See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <[email protected]>
Hey guys, I noticed this was added to the 2.0 release although I don't see it in the changelog. I suspect this was scoped out of 2.0. The abstractions provided would be useful! Do you have plans to include it in a future release? If so, is there anything I can do to help? Thanks! |
Hey @kylejuliandev, @askpt is working on a draft PR. Feel free to review the PR and provide feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @austindrenski in open-feature/dotnet-sdk-contrib#125 (comment)
The text was updated successfully, but these errors were encountered: