chore: Reduce dependency on MEL -> MELA #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main open-feature/dotnet-sdk-contrib#176 +/- ##
==========================================
+ Coverage 94.30% 94.73% +0.42%
==========================================
Files 21 23 +2
Lines 650 931 +281
Branches 54 93 +39
==========================================
+ Hits 613 882 +269
- Misses 23 29 +6
- Partials 14 20 +6 ☔ View full report in Codecov by Sentry. |
Ran across this while working on open-feature/dotnet-sdk-contrib#127, but tldr; libraries don't need the implementation package, so reduce to the abstractions package to remove transitive dependencies on: - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Options - (and a few others depending on the TFM) Signed-off-by: Austin Drenski <[email protected]>
austindrenski
force-pushed
the
shrink-microsoft-extensions-logging-dep
branch
from
52a4b6e
to
36791a6
Compare
austindrenski
changed the title
toddbaert
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across this while working on #264, but tldr; libraries don't need the implementation package, so reduce to the abstractions package to remove transitive dependencies on:
Microsoft.Extensions.DependencyInjectionMicrosoft.Extensions.Options