Apply suggestions from code review

Co-authored-by: Skye Gill <[email protected]> Signed-off-by: James Milligan <[email protected]>
open-feature · Mar 1, 2023 · c60db46 · c60db46
1 parent 8c2b391
commit c60db46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/store/flags.go b/pkg/store/flags.go
@@ -22,9 +22,10 @@ func (f *Flags) hasPriority(stored string, new string) bool {
 		return true
 	}
 	for i := len(f.FlagSources) - 1; i >= 0; i-- {
-		if f.FlagSources[i] == stored {
+		switch f.FlagSources[i] {
+		case stored:
 			return false
-		} else if f.FlagSources[i] == new {
+		case new:
 			return true
 		}
 	}

diff --git a/pkg/sync/grpc/grpc_sync.go b/pkg/sync/grpc/grpc_sync.go
@@ -62,7 +62,7 @@ func (g *Sync) connectClient(ctx context.Context) error {
 func (g *Sync) ReSync(ctx context.Context, dataSync chan<- sync.DataSync) error {
 	res, err := g.client.FetchAllFlags(ctx, &v1.FetchAllFlagsRequest{})
 	if err != nil {
-		g.Logger.Error(fmt.Sprintf("error fetching all flags: %s", err.Error()))
+		g.Logger.Error(fmt.Sprintf("fetching all flags: %s", err.Error()))
 		return err
 	}
 	dataSync <- sync.DataSync{