Can we close sync_service server without closing the listener first

[apodgorbunschih]

Hello People,

I am using FlagD in a K8S cluster, and I see a lot of warning like error from sync server start: accept tcp [::]:8015: use of closed network connection

When debugging I found that the shutdown is closing first the listener then the server

flagd/flagd/pkg/service/flag-sync/sync_service.go

Lines 121 to 127 in ae24595

	func (s *Service) shutdown() {
	err := s.listener.Close()
	if err != nil {
	s.logger.Warn(fmt.Sprintf("error closing the listener: %v", err))
	}
	s.server.Stop()
	}

When the listener is closed the server is now having a closed connection that is leading to the above warnings.

Is it possible to stop the server without closing the listener ?

I see that in the s.server.Stop() is a calling s.closeListenersLocked() but not sure if its different from s.listener.Close()

This is the testing scenario.

[Kavindu-Dodan]

@apodgorbunschih thanks for reporting this behavior. Yes, s.server.Stop() (grpc server stop) already close the internal listener. I opened #1375 to improve this

[apodgorbunschih]

@Kavindu-Dodan Thanks a lot for such a quick fix ❤️