Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ResolveAll endpoint for bulk evaluation #239

Merged
merged 26 commits into from
Jan 12, 2023
Merged

feat: ResolveAll endpoint for bulk evaluation #239

merged 26 commits into from
Jan 12, 2023

Conversation

james-milligan
Copy link
Contributor

This PR

  • introduces the resolve all endpoint for bulk flag evaluation

Related Issues

#234

Notes

Follow-up Tasks

How to test

@james-milligan
initial feat commit
c2ba4d4 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
removed comment
57e8b67 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
package switch
7139560 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
add example
c1d7a08 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
merge
d7f7c73 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting
1f9d23d 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting
6bf84ed 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fixes
c14f506 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Copy link
Contributor Author

LINTING FIXES:
Added the //nolint:funlen annotation to the Notify function of Kubernetes_sync.go. To drop the functions lines by 2 we will need to abstract out functionality that is used once, or drop comments. Both options will make the code more confusing for developers.

@james-milligan james-milligan marked this pull request as ready for review December 21, 2022 15:00
@toddbaert toddbaert self-requested a review January 3, 2023 15:08
@toddbaert
Copy link
Member

I tested this and it works as expected. I agree with @skyerus that it might be nice to reduce some duplication, but that may not be possible.

@beeme1mr beeme1mr requested a review from skyerus January 4, 2023 16:09
@beeme1mr beeme1mr linked an issue Jan 5, 2023 that may be closed by this pull request
[FEATURE] flagd bulk evaluation #234
Closed
4 tasks
james-milligan and others added 6 commits January 6, 2023 09:38
@james-milligan
cleanup
ebdbce8 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
cleanup
8f04daf 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
tests
7c03566 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge branch 'main' into resolve-all
360069f
@james-milligan
expanded test
7df6551 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge branch 'resolve-all' of https://github.com/james-milligan/flagd …
24d2f2a 
…into resolve-all
skyerus
skyerus reviewed Jan 6, 2023
View reviewed changes
pkg/eval/json_evaluator.go Outdated Show resolved Hide resolved
pkg/service/connect_service.go Outdated Show resolved Hide resolved
@james-milligan
updated log level for resolveAll errors
4bb24ca 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
merge
cc02083 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan merged commit 6437c43 into open-feature:main Jan 12, 2023
@github-actions github-actions bot mentioned this pull request Jan 12, 2023
Merged
james-milligan pushed a commit that referenced this pull request Jan 12, 2023
@github-actions
chore(main): release 0.3.1 (#253)
7a1b1ef 
🤖 I have created a release *beep* *boop*
---


##
[0.3.1](v0.3.0...v0.3.1)
(2023-01-12)


### Features

* file extension detection
([#257](#257))
([ca22541](ca22541))
* ResolveAll endpoint for bulk evaluation
([#239](#239))
([6437c43](6437c43))


### Bug Fixes

* **deps:** update module github.com/bufbuild/connect-go to v1.4.1
([#268](#268))
([712d7dd](712d7dd))
* **deps:** update module github.com/mattn/go-colorable to v0.1.13
([#260](#260))
([5b11504](5b11504))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.23 ([#261](#261))
([a1dd3b9](a1dd3b9))
* **deps:** update module github.com/rs/cors to v1.8.3
([#264](#264))
([0e6f2f3](0e6f2f3))
* **deps:** update module github.com/stretchr/testify to v1.8.1
([#265](#265))
([2ec61c6](2ec61c6))
* improve invalid sync URI errror msg
([#252](#252))
([5939870](5939870))
* replace character slice with regex replace
([#250](#250))
([c92d101](c92d101))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyerus skyerus skyerus approved these changes

@toddbaert toddbaert toddbaert approved these changes

@AlexsJones AlexsJones Awaiting requested review from AlexsJones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] flagd bulk evaluation
3 participants
@james-milligan @toddbaert @skyerus