fix: replace character slice with regex replace #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes also mean that we no longer need to cc @vadasambar |
Thank you and yes, we can replace |
toddbaert
approved these changes
Jan 10, 2023
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
beeme1mr
approved these changes
Jan 11, 2023
james-milligan
pushed a commit
that referenced
this pull request
Jan 12, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2023-01-12) ### Features * file extension detection ([#257](#257)) ([ca22541](ca22541)) * ResolveAll endpoint for bulk evaluation ([#239](#239)) ([6437c43](6437c43)) ### Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.4.1 ([#268](#268)) ([712d7dd](712d7dd)) * **deps:** update module github.com/mattn/go-colorable to v0.1.13 ([#260](#260)) ([5b11504](5b11504)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.23 ([#261](#261)) ([a1dd3b9](a1dd3b9)) * **deps:** update module github.com/rs/cors to v1.8.3 ([#264](#264)) ([0e6f2f3](0e6f2f3)) * **deps:** update module github.com/stretchr/testify to v1.8.1 ([#265](#265)) ([2ec61c6](2ec61c6)) * improve invalid sync URI errror msg ([#252](#252)) ([5939870](5939870)) * replace character slice with regex replace ([#250](#250)) ([c92d101](c92d101)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Milligan [email protected]
This PR
Related Issues
#244
Notes
switches from a hard coded
1:n-2slice to use regex to match and replace the first{and last}in the string.Follow-up Tasks
How to test