feat!: consolidated configuration change events into one event #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
force-pushed
the
issue-238_configuration-change-event
branch
from
f308986
to
35060a8
Compare
skyerus
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
skyerus
force-pushed
the
issue-238_configuration-change-event
branch
from
35060a8
to
edf6e6a
Compare
|
Converting to draft until checklist in description is complete |
toddbaert
approved these changes
Jan 4, 2023
james-milligan
approved these changes
Jan 4, 2023
This was referenced Jan 4, 2023
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-238_configuration-change-event
branch
from
edf6e6a
to
8850bbb
Compare
beeme1mr
pushed a commit
that referenced
this pull request
Jan 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.7...v0.3.0) (2023-01-06) ### ⚠ BREAKING CHANGES * consolidated configuration change events into one event ([#241](#241)) ### Features * consolidated configuration change events into one event ([#241](#241)) ([f9684b8](f9684b8)) * support yaml evaluator ([#206](#206)) ([2dbace5](2dbace5)) ### Bug Fixes * changed eventing configuration mutex to rwmutex and added missing lock ([#220](#220)) ([5bbef9e](5bbef9e)) * omitempty targeting field in Flag structure ([#247](#247)) ([3f406b5](3f406b5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Consolidates configuration change events into a singular event (avoid superfluous bulk emissions).
Existing
configuration_changeevent listeners will need to update their handling to consume the singular events.Related Issues
Fixes #238
Notes
Follow-up Tasks
How to test