feat: handle consolidated configuration change event #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-64_event-stream-consolidation
branch
from
7217c3c
to
3d6d4fb
Compare
james-milligan
approved these changes
Jan 4, 2023
|
A linting issue has been flagged in the actions, but otherwise LGTM
|
Signed-off-by: Skye Gill <[email protected]>
beeme1mr
approved these changes
Jan 6, 2023
Merged
skyerus
added a commit
to open-feature/flagd
that referenced
this pull request
Jan 6, 2023
## This PR Consolidates configuration change events into a singular event (avoid superfluous bulk emissions). Existing `configuration_change` event listeners will need to update their handling to consume the singular events. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #238 - [x] [Update go-sdk-contrib](open-feature/go-sdk-contrib#66) - [ ] Update java-sdk-contrib ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> Signed-off-by: Skye Gill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Handles the consolidated configuration change event.
Related Issues
Fixes #64
Release in conjunction with open-feature/flagd#241
Notes
Follow-up Tasks
How to test