-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Unify case usage, seperators and punctuation for logging #298
Labels
enhancement
New feature or request
good first issue
Good for newcomers
Needs Triage
This issue needs to be investigated by a maintainer
Comments
Kavindu-Dodan
added
enhancement
New feature or request
Needs Triage
This issue needs to be investigated by a maintainer
labels
Jan 20, 2023
Kavindu-Dodan
changed the title
[FEATURE] Unify case usage, seperators and punctuation for logging
[REFACTOR] Unify case usage, seperators and punctuation for logging
Jan 20, 2023
toddbaert
added
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Jan 20, 2023
Hi, can I be assigned this issue or should I directly submit my PR here? |
Sure, thanks @mihirm21! |
This was referenced Jan 22, 2023
Could this be merged though DCO not permitting since I am unable to sign off my commit. |
Hey @mihirm21, you should be able to run these commands to sign off on your previous commits. To add your Signed-off-by line to every commit in this branch:
Please let me know if you run into any issues. |
This was referenced Jan 25, 2023
plz check my PR |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
Needs Triage
This issue needs to be investigated by a maintainer
Requirements
Flagd logs have mixed usage of uppercase and lowercase.
je.Logger.Error(fmt.Sprintf("parseFractionalEvaluationData: %v", err))
vsfs.Logger.Error(fmt.Sprintf("Error fetching after Create notification: %s", err.Error()))
This issue focuses on unifying case usage throughout the source and setting the standards for logging formats.
Prefered first letter case - lowercase
ex:- fs.Logger.Debug("configuration modified")
Prefered separator for details - :
(Note the
:
usage for for uri detail )ex:- Logger.Info(fmt.Sprintf("watching filepath: %s", fs.URI))
Prefer log line end punctuation - NONE (i.e - No full stop)
ex:- fs.Logger.Info("Starting filepath sync notifier")
The text was updated successfully, but these errors were encountered: