feat: unified source code #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat : Unify case usage, seperators and punctuation for logging
feat : back to normal Signed-off-by: Mihir Mittal <[email protected]>
mihirm21
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
…ure#296) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/viper](https://togithub.com/spf13/viper) | require | minor | `v1.14.0` -> `v1.15.0` | --- ### Release Notes <details> <summary>spf13/viper</summary> ### [`v1.15.0`](https://togithub.com/spf13/viper/releases/tag/v1.15.0) [Compare Source](https://togithub.com/spf13/viper/compare/v1.14.0...v1.15.0) <!-- Release notes generated using configuration in .github/release.yml at v1.15.0 --> #### What's Changed ##### Exciting New Features 🎉 - feat: add multiple endpoints support for remote by [@​mozartz](https://togithub.com/mozartz) in [https://github.com/spf13/viper/pull/1464](https://togithub.com/spf13/viper/pull/1464) ##### Enhancements 🚀 - Add DocBlock to WatchConfig by [@​glebik000](https://togithub.com/glebik000) in [https://github.com/spf13/viper/pull/1467](https://togithub.com/spf13/viper/pull/1467) ##### Breaking Changes 🛠 - Drop YAML v2 and TOML v1 by [@​sagikazarmark](https://togithub.com/sagikazarmark) in [https://github.com/spf13/viper/pull/1493](https://togithub.com/spf13/viper/pull/1493) - Drop support for Go 1.16 by [@​sagikazarmark](https://togithub.com/sagikazarmark) in [https://github.com/spf13/viper/pull/1494](https://togithub.com/spf13/viper/pull/1494) ##### Dependency Updates ⬆️ - build(deps): bump github.com/spf13/afero from 1.9.2 to 1.9.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1465](https://togithub.com/spf13/viper/pull/1465) - build(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1475](https://togithub.com/spf13/viper/pull/1475) - build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.5 to 2.0.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1466](https://togithub.com/spf13/viper/pull/1466) - build(deps): bump mheap/github-action-required-labels from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1482](https://togithub.com/spf13/viper/pull/1482) - build(deps): bump github.com/subosito/gotenv from 1.4.1 to 1.4.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1488](https://togithub.com/spf13/viper/pull/1488) - build(deps): bump github.com/sagikazarmark/crypt from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/viper/pull/1490](https://togithub.com/spf13/viper/pull/1490) #### New Contributors - [@​choar816](https://togithub.com/choar816) made their first contribution in [https://github.com/spf13/viper/pull/1481](https://togithub.com/spf13/viper/pull/1481) - [@​lol768](https://togithub.com/lol768) made their first contribution in [https://github.com/spf13/viper/pull/1485](https://togithub.com/spf13/viper/pull/1485) - [@​mozartz](https://togithub.com/mozartz) made their first contribution in [https://github.com/spf13/viper/pull/1464](https://togithub.com/spf13/viper/pull/1464) - [@​glebik000](https://togithub.com/glebik000) made their first contribution in [https://github.com/spf13/viper/pull/1467](https://togithub.com/spf13/viper/pull/1467) **Full Changelog**: spf13/viper@v1.14.0...v1.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS40In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Mihir Mittal <[email protected]>
Signed-off-by: Mihir Mittal <[email protected]>
feat : Unify case usage, seperators and punctuation for logging Signed-off-by: Mihir Mittal <[email protected]>
beeme1mr
requested changes
Jan 24, 2023
](https://renovatebot.com){kind=link}
cmd/root.go
Outdated
| @@ -19,8 +19,8 @@ var ( | |||
|
|
|||
| var rootCmd = &cobra.Command{ | |||
| Use: "flagd", | |||
| Short: "Flagd is a simple command line tool for fetching and presenting feature flags to services. " + | |||
| "It is designed to conform to Open Feature schema for flag definitions.", | |||
| Short: "flagd is a simple command line tool for fetching and presenting feature flags to services" + | |||
There was a problem hiding this comment.
Please revert the change made to the short description.
| "Please note that yaml/yml and json evaluations work the same (yaml/yml files are converted to json internally)") | ||
| flags.StringP(serverCertPathFlagName, "c", "", "Server side tls certificate path") | ||
| flags.StringP(serverKeyPathFlagName, "k", "", "Server side tls key path") | ||
| flags.Int32P(metricsPortFlagName, "m", 8014, "port to serve metrics on") |
There was a problem hiding this comment.
Please revert the flag argument description changes.
cmd/version.go
Outdated
| @@ -10,7 +10,7 @@ import ( | |||
| // versionCmd represents the version command | |||
| var versionCmd = &cobra.Command{ | |||
| Use: "version", | |||
| Short: "Print the version number of FlagD", | |||
| Short: "print the version number of flagd", | |||
docs/configuration/configuration.md
Outdated
| @@ -6,16 +6,16 @@ highest priority, followed by environment variables and finally config file. | |||
| Supported flags are as follows (result of running `./flagd start --help`): | |||
|
|
|||
| ``` | |||
| -b, --bearer-token string Set a bearer token to use for remote sync | |||
| -b, --bearer-token string set a bearer token to use for remote sync | |||
pkg/logger/logger.go
Outdated
| @@ -168,7 +168,7 @@ func (l *Logger) ClearFields(reqID string) { | |||
| // NewZapLogger creates a *zap.Logger using the base config | |||
| func NewZapLogger(level zapcore.Level) (*zap.Logger, error) { | |||
| cfg := zap.Config{ | |||
| Encoding: "json", | |||
| Encoding: "console", | |||
There was a problem hiding this comment.
Please revert this change. It should be handled in a separate PR.
pkg/service/connect_metrics.go
Outdated
| @@ -141,23 +141,23 @@ func NewRecorder(cfg prometheusConfig) *MetricsRecorder { | |||
| Namespace: cfg.Prefix, | |||
| Subsystem: "http", | |||
| Name: "request_duration_seconds", | |||
| Help: "The latency of the HTTP requests.", | |||
| Help: "the latency of the HTTP requests", | |||
There was a problem hiding this comment.
Please the help descriptions for all the connect metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Mittal <[[email protected]]>
This PR
[REFACTOR] Unify case usage, separators, and punctuation for log
Related Issues
Fixes #298
Notes
Follow-up Tasks
How to test