Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filepath sync hangs when a sibling sync fails on startup #356

Closed
james-milligan opened this issue Feb 1, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer

Comments

@james-milligan
Copy link
Contributor

james-milligan commented Feb 1, 2023

Observed behavior

When a sync fails on startup no error is thrown, and remaining syncs hang

Expected Behavior

Error log indicating that the file config/samples/I-dont-exist.json does not exist

Steps to reproduce

start flagd with the following command:

./flagd start --uri file:config/samples/example_flags.json --uri file:config/samples/I-dont-exist.json --debug 

output:

1.6752602188585558e+09  debug   runtime/from_config.go:76       using filepath sync-provider for: "file:config/samples/example_flags.json"      {"component": "runtime"}
1.675260218858582e+09   debug   runtime/from_config.go:76       using filepath sync-provider for: "file:config/samples/I-dont-exist.json"       {"component": "runtime"}
1.6752602188586729e+09  info    file/filepath_sync.go:29        Starting filepath sync notifier {"component": "sync", "sync": "filepath"}
1.67526021885871e+09    info    file/filepath_sync.go:29        Starting filepath sync notifier {"component": "sync", "sync": "filepath"}
1.6752602188590488e+09  info    service/connect_service.go:108  metrics listening at 8014       {"component": "service"}

with the console hanging
No response

@james-milligan james-milligan added bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer labels Feb 1, 2023
@james-milligan james-milligan self-assigned this Feb 1, 2023
toddbaert pushed a commit that referenced this issue Feb 1, 2023
Signed-off-by: James Milligan <[email protected]>

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- buffers channel on startup to prevent blocking in linked issue

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

#356

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

Signed-off-by: James Milligan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant