Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Broken sbom generation #379

Closed
Kavindu-Dodan opened this issue Feb 6, 2023 · 0 comments · Fixed by #380 or #381
Closed

[BUG] Broken sbom generation #379

Kavindu-Dodan opened this issue Feb 6, 2023 · 0 comments · Fixed by #380 or #381
Assignees
@Kavindu-Dodan
Labels
bug Something isn't working

Comments

@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Feb 6, 2023 •
edited
Loading

Observed behavior

Consider the GH action for release https://github.com/open-feature/flagd/actions/runs/4105386972

This is broken as sbom artifact is set to (derived from IMAGE_NAME) openfeature/flagd, which is a folder path instead of a file flagd.

Expected Behavior

Action must be corrected to use a file name. This can be hardcoded as we do not have any constant readily available.

The simple fix [1]

From :

artifact-name: ${{ format('{0}-{1}-sbom.spdx',env.IMAGE_NAME, needs.release-please.outputs.release_tag_name) }}

To :

artifact-name: ${{ format('flagd-{0}-sbom.spdx, needs.release-please.outputs.release_tag_name) }}

[1]. - https://github.com/open-feature/flagd/blob/main/.github/workflows/release-please.yaml#L102
@Kavindu-Dodan Kavindu-Dodan added bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer labels Feb 6, 2023
@Kavindu-Dodan Kavindu-Dodan self-assigned this Feb 6, 2023
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Feb 6, 2023
Merged
@github-actions github-actions bot mentioned this issue Feb 6, 2023
Merged
@Kavindu-Dodan Kavindu-Dodan removed the Needs Triage This issue needs to be investigated by a maintainer label Feb 6, 2023
Kavindu-Dodan pushed a commit that referenced this issue Feb 13, 2023
@github-actions
chore(main): release 0.3.7 (#381)
b71729a 
🤖 I have created a release *beep* *boop*
---


##
[0.3.7](v0.3.6...v0.3.7)
(2023-02-13)


### Bug Fixes

* **deps:** update module golang.org/x/net to v0.6.0
([#396](#396))
([beb7564](beb7564))
* **deps:** update module google.golang.org/grpc to v1.53.0
([#388](#388))
([174cd7c](174cd7c))
* error handling of Serve/ServeTLS funcs
([#397](#397))
([8923bf2](8923bf2))
* fix race in http sync test
([#401](#401))
([1d0c8e1](1d0c8e1))
* sbom artefact name
([#380](#380))
([3daef26](3daef26)),
closes [#379](#379)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this issue Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kavindu-Dodan Kavindu-Dodan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sbom artefact name Kavindu-Dodan/flagd
chore(main): release 0.3.7 open-feature/flagd
1 participant
@Kavindu-Dodan