chore: Add targeted Flag to example config #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new flag because in open-feature/killercoda#5 I'm trying to explain targeting. This example is explicit in that: - Everyone gets `first` except - Those with `email` containing `@openfeature.dev` - get `second` - Those with `userAgent` containing `Chrome` - get `third`. Signed-off-by: Adam Gardner <[email protected]>
agardnerIT
requested review from
AlexsJones,
james-milligan,
toddbaert and
Kavindu-Dodan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 62.12% 62.12%
=======================================
Files 13 13
Lines 1650 1650
=======================================
Hits 1025 1025
Misses 562 562
Partials 63 63 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
reviewed
Mar 6, 2023
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
|
I've also added (what I think) is the correct YAML definition. Please do check that closely. |
beeme1mr
reviewed
Mar 7, 2023
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Adam Gardner <[email protected]>
beeme1mr
approved these changes
Mar 7, 2023
toddbaert
approved these changes
Mar 8, 2023
beeme1mr
changed the title
beeme1mr
pushed a commit
that referenced
this pull request
Mar 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.2](v0.4.1...v0.4.2) (2023-03-09) ### 🧹 Chore * Add targeted Flag to example config ([#467](#467)) ([6a039ce](6a039ce)) * **deps:** pin dependencies ([#473](#473)) ([679e860](679e860)) * **deps:** update google-github-actions/release-please-action digest to e0b9d18 ([#474](#474)) ([5b85b2a](5b85b2a)) * refactoring and improve coverage for K8s Sync ([#466](#466)) ([6dc441e](6dc441e)) ### 🐛 Bug Fixes * add registry login ([#476](#476)) ([99de755](99de755)) * **deps:** update module golang.org/x/crypto to v0.7.0 ([#472](#472)) ([f53f6c8](f53f6c8)) * **deps:** update module google.golang.org/protobuf to v1.29.0 ([#478](#478)) ([f9adc8e](f9adc8e)) ### ✨ New Features * grpc tls connectivity (grpcs) ([#477](#477)) ([228f430](228f430)) * introduce per-sync configurations ([#448](#448)) ([1d80039](1d80039)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new flag because in open-feature/killercoda#5 I'm trying to explain targeting.
This example is explicit in that:
firstexceptemailcontaining@openfeature.dev- getseconduserAgentcontainingChrome- getthird.