-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aligned environment variables application with flagd provider spec #119
Conversation
Signed-off-by: Skye Gill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the readme.
https://github.com/open-feature/go-sdk-contrib/tree/main/providers/flagd
While you're there, you can go ahead and remove the experimental and alpha badges.
providers/flagd/pkg/provider.go
Outdated
if maxCacheSizeS != "" { | ||
maxCacheSizeFromEnv, err := strconv.Atoi(maxCacheSizeS) | ||
if err != nil { | ||
p.logger.Error(err, fmt.Sprintf("invalid env config for %s provided, using default value", flagdMaxCacheSizeEnvironmentVariableName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor - should we state the default value in the log 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Addressing my comment is optional
Signed-off-by: Skye Gill <[email protected]>
Well spotted, done. |
This PR
Aligns environment variables with flagd provider spec: https://github.com/open-feature/flagd/blob/main/docs/other_resources/creating_providers.md?plain=1#L117
FLAGD_CACHING_DISABLED environment variable superseded by FLAGD_CACHE. Set FLAGD_CACHE to
disabled
to sustain previous behavior.Related Issues
Fixes #117
Notes
Follow-up Tasks
How to test