feat: aligned environment variables application with flagd provider spec #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Skye Gill <[email protected]>
james-milligan
approved these changes
Feb 17, 2023
beeme1mr
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Please also update the readme.
https://github.com/open-feature/go-sdk-contrib/tree/main/providers/flagd
While you're there, you can go ahead and remove the experimental and alpha badges.
providers/flagd/pkg/provider.go
Outdated
| if maxCacheSizeS != "" { | ||
| maxCacheSizeFromEnv, err := strconv.Atoi(maxCacheSizeS) | ||
| if err != nil { | ||
| p.logger.Error(err, fmt.Sprintf("invalid env config for %s provided, using default value", flagdMaxCacheSizeEnvironmentVariableName)) |
There was a problem hiding this comment.
Minor - should we state the default value in the log 🤔 ?
Kavindu-Dodan
approved these changes
Feb 21, 2023
toddbaert
approved these changes
Feb 21, 2023
Signed-off-by: Skye Gill <[email protected]>
Well spotted, done. |
beeme1mr
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Aligns environment variables with flagd provider spec: https://github.com/open-feature/flagd/blob/main/docs/other_resources/creating_providers.md?plain=1#L117
FLAGD_CACHING_DISABLED environment variable superseded by FLAGD_CACHE. Set FLAGD_CACHE to
disabledto sustain previous behavior.Related Issues
Fixes #117
Notes
Follow-up Tasks
How to test