Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use component_owners #446

Merged
merged 2 commits into from
Jul 12, 2023
Merged

chore: use component_owners #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b911815
fixup: use component-owners instead
toddbaert Jul 10, 2023
3b310ea
fixup: pin version, add perms
toddbaert Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/component_owners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Keep all in alphabetical order
components:
libs/hooks/open-telemetry:
- beeme1mr
- toddbaert
libs/providers/config-cat:
- lukas-reining
lukas-reining marked this conversation as resolved.
Show resolved Hide resolved
libs/providers/env-var:
- beeme1mr
- toddbaert
libs/providers/flagd:
- beeme1mr
- toddbaert
libs/providers/flagd-web:
- beeme1mr
- toddbaert
libs/providers/go-feature-flag:
- thomaspoignant
libs/providers/in-memory:
- moredip
- beeme1mr
- toddbaert
libs/providers/launchdarkly-client:
- kinyoklion
- mateoc
- sago2k8

ignored-authors:
- renovate-bot
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
18 changes: 18 additions & 0 deletions .github/workflows/component-owners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: 'Component Owners'
on:
pull_request_target:

permissions:
contents: read # to read changed files
issues: read|write # to read/write issue assignees
pull-requests: read|write # to read/write PR reviewers
Comment on lines +5 to +8
Copy link
Member Author

@toddbaert toddbaert Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinyoklion I've added the permissions as you suggested, good idea.

@dyladan I looked through the source and cross-referenced the REST calls I saw there with the GH doc, and came up with the permissions above. If this looks good to you, and it works, I can open a PR to document this in your sample workflow.

EDIT: read|write is invalid. I changed this to write, which implies read. After that this worked well.


jobs:
run_self:
runs-on: ubuntu-latest
name: Auto Assign Owners
steps:
- uses: dyladan/component-owners@95fcb98c201ff5a41f6b9df38caad4bf9bf4ef02
with:
config-file: .github/component_owners.yml
repo-token: ${{ secrets.GITHUB_TOKEN }}